Skip to content

BL-15421 placeholders in thumbnails adding pages from template starter#7654

Merged
andrew-polk merged 1 commit intoVersion6.3from
BL-15825_template_thumbnail_placeholders
Feb 5, 2026
Merged

BL-15421 placeholders in thumbnails adding pages from template starter#7654
andrew-polk merged 1 commit intoVersion6.3from
BL-15825_template_thumbnail_placeholders

Conversation

@nabalone
Copy link
Contributor

@nabalone nabalone commented Feb 4, 2026

This change is Reviewable


Open with Devin

Copy link

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional flags.

Open in Devin Review

@nabalone nabalone force-pushed the BL-15825_template_thumbnail_placeholders branch from 72a7104 to 16c0aff Compare February 5, 2026 18:32
@nabalone nabalone marked this pull request as ready for review February 5, 2026 18:34
Copy link

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View 3 additional findings in Devin Review.

Open in Devin Review

Copy link
Contributor

@andrew-polk andrew-polk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrew-polk reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nabalone).


src/content/bookLayout/basePage.less line 104 at r2 (raw file):

// When making a thumbnail for a template page, add a kind of text mockup to text areas
.bloom-templateThumbnail {

This really doesn't belong in basePage.less. It wants to be in a separate stylesheet which only gets added for the thumbnail case. Otherwise, this gets added to every book. But obviously we aren't making that change as part of this PR.

@andrew-polk andrew-polk merged commit 345a9a1 into Version6.3 Feb 5, 2026
2 checks passed
@andrew-polk andrew-polk deleted the BL-15825_template_thumbnail_placeholders branch February 5, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants