Refactor canvas elements: registry-driven controls#7621
Draft
Refactor canvas elements: registry-driven controls#7621
Conversation
CanvasElementManager had grown too large and UI affordances (context menu + mini toolbar) were being assembled imperatively, which made ordering/section dividers hard to reason about and encouraged cross-bundle imports. This change introduces a declarative canvas element registry that drives which buttons and menus are available per element type. It also makes context menu/mini-toolbar composition deterministic: fixed section ordering, exactly one divider/spacer between non-empty sections, and Duplicate/Delete always last. To reduce runtime import-cycle risk across the edit view + toolbox bundles, DOM selectors/constants move to a dependency-light module (canvasElementConstants) while canvasElementUtils is narrowed to a cross-frame bridge (getCanvasElementManager) with type-only imports. CanvasElementManager is partially decomposed into focused helper modules (Geometry/Positioning/Alternates) plus public-function wrappers, and related call sites were updated. Misc hardening: safer MUI Menu anchoring, avoid non-null assertions, fix closest() selector typo, and remove duplicate pxToNumber helper. Follow-ups in this series: - Make mini-toolbar + menu more declarative and consistent - Make `toolbarButtons` the sole source of truth for the mini-toolbar (including explicit spacers) and normalize spacer runs. - Share menu + toolbar definitions via a single command registry to keep icons/tooltips/click behavior in sync. - Replace “Set Up Hyperlink” with the “Set Destination” command in this context, and do not show either on simple image elements.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| canvasElementLangIn?: string, | ||
| ): void => { | ||
| const canvasElementLang = | ||
| canvasElementLangIn ?? GetSettings().languageForNewTextBoxes; |
There was a problem hiding this comment.
🔴 Missing GetSettings() type declaration in CanvasElementAlternates.ts causes TypeScript error
The new file CanvasElementAlternates.ts uses the globally injected GetSettings() function at line 12 but lacks the required triple-slash reference directive to declare it.
Click to expand
Problem
The file calls GetSettings().languageForNewTextBoxes but GetSettings is not declared in scope. This function is injected by C# at runtime, but TypeScript needs the type declaration to compile.
Evidence
Other files in the codebase that use GetSettings() include the reference directive:
CanvasElementManager.ts:8:/// <reference path="./collectionSettings.d.ts"/>BloomSourceBubbles.tsx:10:/// <reference path="../js/collectionSettings.d.ts"/>StyleEditor.ts:11:/// <reference path="../js/collectionSettings.d.ts"/>PlaceholderProvider.ts:5:/// <reference path="./collectionSettings.d.ts" />BloomHintBubbles.ts:5:/// <reference path="./collectionSettings.d.ts" />
Impact
This will cause a TypeScript compilation error: Cannot find name 'GetSettings'.
Recommendation: Add the triple-slash reference directive at the top of the file:
/// <reference path="../collectionSettings.d.ts"/>
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CanvasElementManager had grown too large and UI affordances (context menu + mini toolbar) were being assembled imperatively, which made ordering/section dividers hard to reason about and encouraged cross-bundle imports.
This change introduces a declarative canvas element registry that drives which buttons and menus are available per element type.
It also makes context menu/mini-toolbar composition deterministic: fixed section ordering, exactly one divider/spacer between non-empty sections, and Duplicate/Delete always last.
To reduce runtime import-cycle risk across the edit view + toolbox bundles, DOM selectors/constants move to a dependency-light module (canvasElementConstants) while canvasElementUtils is narrowed to a cross-frame bridge (getCanvasElementManager) with type-only imports.
CanvasElementManager is partially decomposed into focused helper modules (Geometry/Positioning/Alternates) plus public-function wrappers, and related call sites were updated. Misc hardening: safer MUI Menu anchoring, avoid non-null assertions, fix closest() selector typo, and remove duplicate pxToNumber helper.
Follow-ups in this series:
Make
toolbarButtonsthe sole source of truth for the mini-toolbar (including explicit spacers) and normalize spacer runs.Share menu + toolbar definitions via a single command registry to keep icons/tooltips/click behavior in sync.
Replace “Set Up Hyperlink” with the “Set Destination” command in this context, and do not show either on simple image elements.
This change is