Fix EpubMaker.MakeManifest to use relative path instead of full path#7510
Closed
Copilot wants to merge 1 commit intoBL-15441_canvas_elementfrom
Closed
Fix EpubMaker.MakeManifest to use relative path instead of full path#7510Copilot wants to merge 1 commit intoBL-15441_canvas_elementfrom
Copilot wants to merge 1 commit intoBL-15441_canvas_elementfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Comment |
Copilot
AI
changed the title
[WIP] Address feedback from PR review on canvas origami element
Fix EpubMaker.MakeManifest to use relative path instead of full path
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
MakeManifestmethod expects a relative path (folder + filename), but was receiving a full absolute path after recent changes, breaking cover image matching in EPUB generation.Changes
MakeManifestcall at line 555 to passkImagesFolder + "/" + Path.GetFileName(epubThumbnailImagePath)instead of the fullepubThumbnailImagePathPath.GetFileNameWithoutExtensionat line 749 and item comparison at line 823)💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
This change is