Skip to content

Provide enough space for the DragActivityTabControl widget (BL-14614) #7011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StephenMcConnel wants to merge 1 commit into
base: Version6.2a
Choose a base branch
from
+13 −1
Open

Provide enough space for the DragActivityTabControl widget (BL-14614) #7011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/BloomBrowserUI/bookEdit/css/editMode.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1303,6 +1303,14 @@ body.hideAllCKEditors .cke_chrome {
top: -8px;
width: 100%;
}
// Very narrow pages need more space for the #drag-activity-tab-control
.above-page-control-container:has(+ .Device16x9Portrait),
.above-page-control-container:has(+ .QuarterLetterPortrait),
.above-page-control-container:has(+ .A6Portrait) {
#drag-activity-tab-control {
top: -22px;
}
}

// we want :blank, but it's not in browsers yet. So we simulate it by a mutation observer
// that adds a class to the editable when it is empty.
Expand Down
6 changes: 5 additions & 1 deletion src/BloomBrowserUI/bookEdit/toolbox/games/DragActivityTabControl.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,11 @@ export const DragActivityTabControl: React.FunctionComponent<{
`}
>
{promptButtonContent && (
<div>
<div
css={css`
margin-right: 20px;
`}
>
{/* // This button is only visible in start mode. I'd prefer
to control that here but it's difficult. visibility
is controlled with #promptButton rules in editMode.less. */}
Expand Down