Make letter boxes grow wide enough for letters (BL-14541)#6982
Draft
JohnThomson wants to merge 1 commit intomasterfrom
Draft
Make letter boxes grow wide enough for letters (BL-14541)#6982JohnThomson wants to merge 1 commit intomasterfrom
JohnThomson wants to merge 1 commit intomasterfrom
Conversation
Contributor
|
Marking as draft as I think it is quite different than the current spec. (Correct me if I'm wrong.) |
BL-14541 grew to be much more complex than this. The current state of this card is handling width fairly well, but failing to get a reasonable height for မြန်မာ unless line height is 1.5, in which case ordinary roman letters overflow mysteriously. Something is wrong with measuring text. There are also many related tasks in the card which are not yet addressed here.
JohnThomson
force-pushed
the
autoGrowGameLetters
branch
from
e9ff266 to
cddcf82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is