Harvester uses legacy theme (or fails if that is not allowed) (BL-13174)#6355
Open
JohnThomson wants to merge 1 commit intoBloomBooks:masterfrom
Open
Harvester uses legacy theme (or fails if that is not allowed) (BL-13174)#6355JohnThomson wants to merge 1 commit intoBloomBooks:masterfrom
JohnThomson wants to merge 1 commit intoBloomBooks:masterfrom
Conversation
The essence of this change is the code in AppearanceSettings that always uses legacy theme if running in harvester mode, the code in BookStorage that throws a special exception if running in harvester mode and not allowed to use legacy, and the code in CreateArtifactsCommand which catches that exception and reports a new error code. I also created a unit test and had to change a few things to let it work; and discovered that one of the arguments to the BookStorage Factory was unused, and removed it from there and various related methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The essence of this change is the code in AppearanceSettings that always uses legacy theme if running in harvester mode, the code in BookStorage that throws a special exception if running in harvester mode and not allowed to use legacy, and the code in CreateArtifactsCommand which catches that exception and reports a new error code. I also created a unit test and had to change a few things to let it work; and discovered that one of the arguments to the BookStorage Factory was unused, and removed it from there and various related methods.
This change is