Fix Papua-Literacy summary to have correct image URL#5969
Open
JohnThomson wants to merge 1 commit intoBloomBooks:Version5.5from
Open
Fix Papua-Literacy summary to have correct image URL#5969JohnThomson wants to merge 1 commit intoBloomBooks:Version5.5from
JohnThomson wants to merge 1 commit intoBloomBooks:Version5.5from
Conversation
gmartin7
suggested changes
Jul 12, 2023
Contributor
gmartin7
left a comment
There was a problem hiding this comment.
This seems to have been fixed by removing the other url components and just keeping the file name, like most of our brandings. Should this PR be closed?
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @JohnThomson)
gmartin7
suggested changes
Jul 12, 2023
Contributor
gmartin7
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @JohnThomson)
src/content/branding/Papua-Literacy/summary.htm line 3 at r1 (raw file):
<div class="vertical"> <div>Organization: Papua Literacy</div> <img src="/bloom/branding/Papua-Literacy/back.png" />
This was fixed in 5.4. (This PR targets 5.5.) Suggest closing...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is