Depricate broken relative timelock jets #326
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The specifications for some of the relative time lock jets are nonsensical and based on a gross misunderstanding of how relative time locks work. They should not be used. However, they are already consensus in Liquid so we cannot elimiante them. But what we can do is rename them in order to dissuade their use. Users can and should use other jets to parse the sequence numbers of individual inputs in order to properly validate relative timelocks.
These fields are only used to implement broken jets. They only remain here because they are not part of consensus and cannot be removed.
The previous version was not the expected behaviour. This new version is more similar to Bitcoin's CSV op-codes, though there are some subtle difference when passed a 0 argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #325.