Use Vault instead of the homebrew nijikokun register code

[tdfischer]

This commit dumps all of the nijikokun register code in favor of using Vault for economic transactions.

[Blockhead2]

Trever,

Hi. Many thanks for the 3 patches you sent. Does the Vault patch mean that
all my users would now need to download, install and configure the Vault
plugin in addition to their economy system?

It certainly looks a cleaner way to support the economies, but I've tried
to keep the number of other plugins required down to a minimum (zero).
Maybe I'll do a poll to find out what people would prefer.

On the other patches it makes sense to only check the players when I have
to, you'll see there is some unfinished code related to dungeons being
active that I'm still working on for boss mobs and dungeon shut down. The
plugin was being passed to the reset so the custom monsters could also be
reset, but clearly neither bit of code is needed at present and can be
removed.

Send me your thoughts on the pros and cons of using Vault.

Regards, John.

On 7 April 2012 15:30, Trever Fischer <
reply@reply.github.com

wrote:

This commit dumps all of the nijikokun register code in favor of using
Vault for economic transactions.

You can merge this Pull Request by running:

git pull https://github.com/tdfischer/Catacombs vault

Or you can view, comment on it, or merge it online at:

#1

-- Commit Summary --

• Use Vault instead of the homebrew nijikokun register code

-- File Changes --

D BOSEconomy.jar (0)
D BOSEconomy7.jar (0)
D Essentials.jar (0)
D MultiCurrency.jar (0)
A Vault.jar (0)
D iCo4.jar (0)
D iCo5.jar (0)
D iCo6.jar (0)
M nbproject/project.properties (14)
D src/com/nijikokun/catacombsregister/payment/Method.java (183)
D src/com/nijikokun/catacombsregister/payment/Methods.java (243)
D src/com/nijikokun/catacombsregister/payment/methods/BOSE6.java (234)
D src/com/nijikokun/catacombsregister/payment/methods/BOSE7.java (223)
D src/com/nijikokun/catacombsregister/payment/methods/EE17.java (223)
D src/com/nijikokun/catacombsregister/payment/methods/MCUR.java (136)
D src/com/nijikokun/catacombsregister/payment/methods/iCo4.java (167)
D src/com/nijikokun/catacombsregister/payment/methods/iCo5.java (243)
D src/com/nijikokun/catacombsregister/payment/methods/iCo6.java (159)
M src/net/steeleyes/catacombs/CatEntityListener.java (2)
M src/net/steeleyes/catacombs/CatMob.java (2)
M src/net/steeleyes/catacombs/CatPlayerListener.java (2)
D src/net/steeleyes/catacombs/CatServerListener.java (79)
M src/net/steeleyes/catacombs/CatUtils.java (44)
M src/net/steeleyes/catacombs/Catacombs.java (68)
M src/plugin.yml (4)
D test/Test/CashEssentialsEco.java (50)
D test/Test/CashiConomy.java (42)

-- Patch Links --

https://github.com/Blockhead2/Catacombs/pull/1.patch
https://github.com/Blockhead2/Catacombs/pull/1.diff

---

Reply to this email directly or view it on GitHub:
#1

[tdfischer]

Vault requires zero configuration. Most servers already have it.

Additionally, it is required on our server to support our custom economy plugin. Vault provides an API for registering economies that aren't supported by the official distribution, as such:

https://github.com/tdfischer/bukkit-caminus/blob/master/src/main/java/us/camin/Plugin.java#L85

If they don't have vault, then the economy system is disabled. But I'd wager that 99% of the plugins out there that use economies (Residence, ChestShop, Mailbox, etc) have Vault as a requirement.

Additionally, not bundling this library reduces the plugin footprint and server memory usage.

[Blockhead2]

Trever,

I pulled the other 2 patches but will hold off on Vault for the moment
until I've tested the temperature a bit with my user base.

Regards, John.

On 9 April 2012 12:58, Trever Fischer <
reply@reply.github.com

wrote:

Vault requires zero configuration. Most servers already have it.

Additionally, it is required on our server to support our custom economy
plugin. Vault provides an API for registering economies that aren't
supported by the official distribution, as such:

https://github.com/tdfischer/bukkit-caminus/blob/master/src/main/java/us/camin/Plugin.java#L85

If they don't have vault, then the economy system is disabled. But I'd
wager that 99% of the plugins out there that use economies (Residence,
ChestShop, Mailbox, etc) have Vault as a requirement.

---

Reply to this email directly or view it on GitHub:
#1 (comment)