Deep comparison slot range#40
Open
CodiePP wants to merge 2 commits into
Open
Conversation
Member
CodiePP
commented
May 25, 2026
CodiePP
commented
- deep comparison over a slot range
- cronjob for deployment to Kubernetes
Signed-off-by: Alexander Diemand <codieplusplus@apax.net>
Signed-off-by: Alexander Diemand <codieplusplus@apax.net>
monoid-is-a-monad
approved these changes
May 27, 2026
Contributor
monoid-is-a-monad
left a comment
monoid-is-a-monad
left a comment
There was a problem hiding this comment.
🌶️ 👍 This is great! Added some improvement suggestions :)
| spec: | ||
| containers: | ||
| - name: bq-deep-check | ||
| image: bq-deep-check |
Contributor
There was a problem hiding this comment.
we could add a tag that would contain the git commit sha or a version, so that we know deterministically which version is deployed
| requests: | ||
| cpu: 100m | ||
| memory: 128Mi | ||
| imagePullPolicy: Always |
Contributor
There was a problem hiding this comment.
also if we have different image tags we could change this to IfNotPresent
| - name: key-secret | ||
| secret: | ||
| secretName: key-bq | ||
| restartPolicy: OnFailure |
Contributor
There was a problem hiding this comment.
Also here maybe we could set this to Never?: ie. if a pod fails, to create a new pod for the next attempt and keep the failed one around, instead of restarting the existing one.
also we could set:
backoffLimit: 2
so that we have 1+2 retries = 3 total runs in case of a failure (the default is 6 I think)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.