Skip to content

Conversation

@rlcc885
Copy link

@rlcc885 rlcc885 commented Oct 22, 2024

(cherry picked from commit f01088d8a53aca6496051120f02ce0acdfb9e67a)

(cherry picked from commit f01088d8a53aca6496051120f02ce0acdfb9e67a)
@rlcc885 rlcc885 closed this Oct 22, 2024
@rlcc885 rlcc885 deleted the feature/groupedrelation-fix branch October 22, 2024 05:26
@rlcc885 rlcc885 restored the feature/groupedrelation-fix branch October 22, 2024 05:26
@Blackdread
Copy link
Owner

Hi, what was it for exactly?

@rlcc885
Copy link
Author

rlcc885 commented Oct 24, 2024

Hi, nice to meet you, when you select the option to group export-file-structure-type: GROUPED_RELATIONS_SEPARATE_VIEWS one-to-one or one-to-many relationships, but they do not exist as such in the schema, empty structures are generated. For example:

relationship ManyToOne {
}
relationship OneToOne {
}

The commit tries to solve it

@Blackdread
Copy link
Owner

Alright.
Why did you decide to close your PR ?

After, the fact that empty ones are generated, I do not mind it, it makes it clear that none were seen/found by the code logic.

@rlcc885
Copy link
Author

rlcc885 commented Oct 24, 2024

Of course, at the programming level there is no problem, but when using the web version of the jdl editor, it marks an error when generating the relationship structure as empty. The focus of the commit was aiming at web integration.
Regarding the reason for closing the PR, it is because I made a missclick to the fork of my account, but I could generate a new one.

@rlcc885 rlcc885 reopened this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants