fix: reject short WBGL signatures without panic#5
Open
tolga-tom-nook wants to merge 2 commits into
Open
Conversation
This was referenced May 24, 2026
Author
|
Pushed a small hardening follow-up to this PR (
Re-verified locally: go test ./workers/handlers
go test ./...
git diff --check pr-5..HEAD |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validateMsgSignatureRoot cause / acceptance proof
validateMsgSignaturedecodes the hex signature and then immediately readssigBytes[64]. A syntactically valid but too-short hex signature such as0x00decodes successfully to one byte, then panics with an index-out-of-range runtime error.This turns malformed user input into a normal validation error instead of crashing the handler path.
Validation
go test ./workers/handlers -run TestValidateMsgSignatureRejectsShortSignature -count=1panicked withindex out of range [64] with length 1go test ./workers/handlers -run TestValidateMsgSignatureRejectsShortSignature -count=1go test ./...Bounty note
Submitting as a focused bridge robustness/security improvement for the Bitgesell bounty/improvement program, especially BitgesellOfficial/bitgesell#81. If approved for payout, USDT/EVM-compatible address:
0x4a76c7E64C08cF29B59eFC640b4ada97A270d428.Assisted by Hermes Agent.