Skip to content

Streamline helper logic and config cloning#1

Merged
BitTheByte merged 2 commits intomainfrom
copilot/cleanup-code-and-remove-unused-functions
Jan 29, 2026
Merged

Streamline helper logic and config cloning#1
BitTheByte merged 2 commits intomainfrom
copilot/cleanup-code-and-remove-unused-functions

Conversation

Copy link
Contributor

Copilot AI commented Jan 29, 2026

Cleanup focused on removing unused helpers and reducing redundant logic paths while preserving behavior.

  • ADB utilities
    • Drop unused overloads and centralize device ID validation in AdbUtil.
  • Session config cloning
    • Introduce FridaSessionConfig.copy() and remove dialog-local cloning logic.
  • Script generation
    • Remove redundant return-type branch and keep null-safe patch field serialization.
FridaSessionConfig cfg = (fixedSessionConfig != null ? fixedSessionConfig : baseSessionConfig).copy();
if (cfg.getDeviceMode() == DeviceMode.USB && !AdbUtil.isValidDeviceId(cfg.getDeviceId())) {
    // handle invalid device selection
}

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: BitTheByte <16452985+BitTheByte@users.noreply.github.com>
Copilot AI changed the title [WIP] Clean up code by removing unused functions and simplifying logic Streamline helper utilities and config cloning Jan 29, 2026
Copilot AI requested a review from BitTheByte January 29, 2026 10:13
Copilot AI changed the title Streamline helper utilities and config cloning Streamline helper logic and config cloning Jan 29, 2026
@BitTheByte BitTheByte marked this pull request as ready for review January 29, 2026 10:47
@BitTheByte BitTheByte merged commit 758db62 into main Jan 29, 2026
1 check passed
@BitTheByte BitTheByte deleted the copilot/cleanup-code-and-remove-unused-functions branch January 29, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants