Skip to content

Conversation

@starfy84
Copy link

@starfy84 starfy84 commented Dec 4, 2025

Ticket: DX-2438

This PR adds support for installing sliding prerelease tags.

For example:

  • v1-beta
  • v1.1-alpha

@starfy84 starfy84 self-assigned this Dec 4, 2025
@starfy84 starfy84 requested a review from a team as a code owner December 4, 2025 15:17
@starfy84
Copy link
Author

starfy84 commented Dec 4, 2025

To the code reviewer:

I do not have write permissions to merge the branch into master, please do so for me!

@ericcrosson-bitgo
Copy link

To the code reviewer:

I do not have write permissions to merge the branch into master, please do so for me!

@starfy84 Are you able to enable auto-merge? I think this will fulfill the same function!

Copy link

@ericcrosson-bitgo ericcrosson-bitgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks @starfy84 !

test(
"should parse a major.minor version with build metadata",
check(
"foo/bar@v1.1+build.123",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not positive this case is necessary?

test(
"should parse a major version with prerelease and number",
check(
"foo/bar@v1-beta.123",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a format we use?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmm maybe not? I'm not too sure 🤔.

Now that I think about it, I don't even know what version this would point to

@starfy84
Copy link
Author

starfy84 commented Dec 4, 2025

Are you able to enable auto-merge? I think this will fulfill the same function!

I cannot auto-merge!

image

@ericcrosson-bitgo ericcrosson-bitgo merged commit 4ed65bf into master Dec 4, 2025
1 check passed
@ericcrosson-bitgo ericcrosson-bitgo deleted the DX-2438-support-sliding-beta-tags branch December 4, 2025 19:26
@github-actions
Copy link

github-actions bot commented Dec 4, 2025

🎉 This PR is included in version 2.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

starfy84 added a commit that referenced this pull request Dec 4, 2025
Ticket: DX-2438

#17 was merged but was not built. This PR runs `npm run build` on master to apply the changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants