-
Notifications
You must be signed in to change notification settings - Fork 0
feat: support sliding prerelease tags #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
To the code reviewer: I do not have write permissions to merge the branch into master, please do so for me! |
@starfy84 Are you able to enable auto-merge? I think this will fulfill the same function! |
ericcrosson-bitgo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- thanks @starfy84 !
| test( | ||
| "should parse a major.minor version with build metadata", | ||
| check( | ||
| "foo/bar@v1.1+build.123", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not positive this case is necessary?
| test( | ||
| "should parse a major version with prerelease and number", | ||
| check( | ||
| "foo/bar@v1-beta.123", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a format we use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmm maybe not? I'm not too sure 🤔.
Now that I think about it, I don't even know what version this would point to
|
🎉 This PR is included in version 2.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |

Ticket: DX-2438
This PR adds support for installing sliding prerelease tags.
For example:
v1-betav1.1-alpha