feat: added opBNB support #7731
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mullapudipruthvik
requested changes
Dec 11, 2025
| }); | ||
| }); | ||
|
|
||
| describe('OpBNB Coin (topbnb)', function () { |
Contributor
There was a problem hiding this comment.
don't duplicate same tests for a new coin, make existing tests work run for all coins
| }; | ||
|
|
||
| // opBNB Testnet specific mock data helpers (chainId: 5611) | ||
| export function getOpBNBTxListRequest(address: string) { |
Contributor
There was a problem hiding this comment.
you probbaly can use existing data
Comment on lines
+430
to
+449
| account( | ||
| '2b5c52f8-0d0c-4a17-8052-d56373f5d264', | ||
| 'topbnb', | ||
| 'opBNB Testnet', | ||
| Networks.test.opbnb, | ||
| 18, | ||
| UnderlyingAsset.OPBNB, | ||
| BaseUnit.ETH, | ||
| [...ETH_FEATURES, CoinFeature.USES_NON_PACKED_ENCODING_FOR_TXDATA, CoinFeature.EIP1559] | ||
| ), | ||
| account( | ||
| '1588f6da-8e43-4535-8e1c-25e53788437b', | ||
| 'opbnb', | ||
| 'opBNB Mainnet', | ||
| Networks.main.opbnb, | ||
| 18, | ||
| UnderlyingAsset.OPBNB, | ||
| BaseUnit.ETH, | ||
| [...ETH_FEATURES, CoinFeature.USES_NON_PACKED_ENCODING_FOR_TXDATA, CoinFeature.EIP1559] | ||
| ), |
Contributor
There was a problem hiding this comment.
do we need to add it here ?
can we not build txns without this ?
Contributor
Author
There was a problem hiding this comment.
Required to enable EIP-1559 transaction support and the tests use getCommon(coin) which calls coins.get(coin) to fetch the network configuration (chainId, name). The coin must be registered in statics for this to work.
HimanshuS2212
force-pushed
the
COIN-6014
branch
from
406a9d3 to
f01a689
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: COIN-6014
TICKET: COIN-6014