SC-2419: message whitelisting per builder #6668
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bhavidhingra
commented
Aug 9, 2025
bhavidhingra
commented
- fix(sdk-core): coins specific message sign validate SC-2419
- feat: add isMessageWhitelisted() in MessageBuilder
- feat(sdk-core): use common isMessageWhitelisted() function
bhavidhingra
force-pushed
the
SC-2419-whitelist-messages
branch
from
dfaa4cc to
fcdec4d
Compare
bhavidhingra
changed the title
bhavidhingra
changed the title
bhavidhingra
force-pushed
the
SC-2419-whitelist-messages
branch
4 times, most recently
from
3077f25 to
4a74b8a
Compare
bhavidhingra
changed the title
bhavidhingra
force-pushed
the
SC-2419-whitelist-messages
branch
3 times, most recently
from
a25a1af to
56d4058
Compare
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR was closed because it has been stalled for 10 days with no activity. |
bhavidhingra
force-pushed
the
SC-2419-whitelist-messages
branch
2 times, most recently
from
31967c0 to
e6edad5
Compare
bhavidhingra
force-pushed
the
SC-2419-whitelist-messages
branch
from
e6edad5 to
1180821
Compare
Contributor
OttoAllmendinger
left a comment
OttoAllmendinger
left a comment
There was a problem hiding this comment.
Automatic comment to flush this PR from my review queue. 🚽🚽🚽
Please re-request another review from the respective team(s) when you are ready for reviews.
Taseen08
reviewed
Nov 24, 2025
Contributor
Taseen08
left a comment
Taseen08
left a comment
There was a problem hiding this comment.
draft, re-request when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.