Merge pull request #6649 from BitGo/feat/COIN-4135

feat: enable bulk erc20 for bsc and coredao chains

Author: hafeezshaik933

modules/statics/src/coinFeatures.ts

@@ -257,6 +257,19 @@ export const SOL_TOKEN_FEATURES_EXCLUDE_SINGAPORE = SOL_TOKEN_FEATURES.filter(
 );
 export const SOL_OFC_TOKEN_FEATURES = [...ACCOUNT_COIN_DEFAULT_FEATURES, CoinFeature.TSS, CoinFeature.TSS_COLD];
 export const APT_OFC_TOKEN_FEATURES = [...ACCOUNT_COIN_DEFAULT_FEATURES, CoinFeature.TSS, CoinFeature.TSS_COLD];
+
+export const BSC_FEATURES = [
+  ...ETH_FEATURES_WITH_STAKING_AND_MMI,
+  CoinFeature.TSS,
+  CoinFeature.TSS_COLD,
+  CoinFeature.EVM_WALLET,
+  CoinFeature.MPCV2,
+  CoinFeature.USES_NON_PACKED_ENCODING_FOR_TXDATA,
+  CoinFeature.STUCK_TRANSACTION_MANAGEMENT_TSS,
+  CoinFeature.CUSTODY_BITGO_FRANKFURT,
+  CoinFeature.BULK_TRANSACTION,
+  CoinFeature.ERC20_BULK_TRANSACTION,
+];
 export const BSC_TOKEN_FEATURES = [...ACCOUNT_COIN_DEFAULT_FEATURES, CoinFeature.BULK_TRANSACTION];
 export const BSC_TOKEN_FEATURES_EXCLUDE_SINGAPORE = [
   ...ACCOUNT_COIN_DEFAULT_FEATURES_EXCLUDE_SINGAPORE,
@@ -490,6 +503,7 @@ export const COREDAO_FEATURES = [
   CoinFeature.EIP1559,
   CoinFeature.STAKING,
   CoinFeature.EIP1559,
+  CoinFeature.ERC20_BULK_TRANSACTION,
 ];
 export const APECHAIN_FEATURES = [
   ...ETH_FEATURES,

modules/statics/src/coins.ts

@@ -85,6 +85,7 @@ import {
   AVAXC_FEATURES,
   BERA_BGT_FEATURES,
   BERA_FEATURES,
+  BSC_FEATURES,
   CELO_FEATURES,
   COREDAO_FEATURES,
   COREUM_FEATURES,
@@ -1137,17 +1138,7 @@ export const coins = CoinMap.fromCoins([
     18,
     UnderlyingAsset.BSC,
     BaseUnit.BSC,
-    [
-      ...ETH_FEATURES_WITH_STAKING_AND_MMI,
-      CoinFeature.TSS,
-      CoinFeature.TSS_COLD,
-      CoinFeature.EVM_WALLET,
-      CoinFeature.MPCV2,
-      CoinFeature.USES_NON_PACKED_ENCODING_FOR_TXDATA,
-      CoinFeature.STUCK_TRANSACTION_MANAGEMENT_TSS,
-      CoinFeature.CUSTODY_BITGO_FRANKFURT,
-      CoinFeature.BULK_TRANSACTION,
-    ]
+    BSC_FEATURES
   ),
   account(
     '0a205427-f7c9-48a4-a238-c4b33ba6384d',
@@ -1157,17 +1148,7 @@ export const coins = CoinMap.fromCoins([
     18,
     UnderlyingAsset.BSC,
     BaseUnit.BSC,
-    [
-      ...ETH_FEATURES_WITH_STAKING_AND_MMI,
-      CoinFeature.TSS,
-      CoinFeature.TSS_COLD,
-      CoinFeature.EVM_WALLET,
-      CoinFeature.MPCV2,
-      CoinFeature.USES_NON_PACKED_ENCODING_FOR_TXDATA,
-      CoinFeature.STUCK_TRANSACTION_MANAGEMENT_TSS,
-      CoinFeature.CUSTODY_BITGO_FRANKFURT,
-      CoinFeature.BULK_TRANSACTION,
-    ]
+    BSC_FEATURES
   ),
   account(
     'f0e226b6-6cd8-4384-b0a5-ba8e4148a049',

modules/statics/src/networks.ts

@@ -1274,8 +1274,6 @@ class CoredaoTestnet extends Testnet implements EthereumNetwork {
   accountExplorerUrl = 'https://scan.test2.btcs.network/address/';
   chainId = 1114;
   nativeCoinOperationHashPrefix = '1114';
-
-  // TODO (SC-1024) Update contract addresses to new testnet when they are deployed
   batcherContractAddress = '0x3e1e5d78e44f15593b3b61ed278f12c27f0ff33e';
   forwarderFactoryAddress = '0x37996e762fa8b671869740c79eb33f625b3bf92a';
   forwarderImplementationAddress = '0xd5fe1c1f216b775dfd30638fa7164d41321ef79b';

modules/statics/test/unit/coins.ts

@@ -1045,17 +1045,25 @@ describe('Bulk Transaction Features', () => {
 
 describe('ERC20 Bulk Transaction Feature', () => {
   it('should have ERC20_BULK_TRANSACTION feature for appropriate coins', () => {
-    const erc20BulkTransactionCoins = ['eth', 'hteth', 'opeth', 'topeth', 'arbeth', 'tarbeth', 'polygon', 'tpolygon'];
+    const erc20BulkTransactionCoins = [
+      'eth',
+      'hteth',
+      'opeth',
+      'topeth',
+      'arbeth',
+      'tarbeth',
+      'polygon',
+      'tpolygon',
+      'coredao',
+      'tcoredao',
+      'bsc',
+      'tbsc',
+    ];
     erc20BulkTransactionCoins.forEach((coinName) => {
       const coin = coins.get(coinName);
       coin.features.includes(CoinFeature.ERC20_BULK_TRANSACTION).should.eql(true);
     });
   });
-
-  it('should not have ERC20_BULK_TRANSACTION feature for BSC', () => {
-    const coin = coins.get('bsc');
-    coin.features.includes(CoinFeature.ERC20_BULK_TRANSACTION).should.eql(false);
-  });
 });
 
 describe('Eip1559 coins', () => {