Skip to content

Commit 7dacd57

Browse files
feat: enable bulk erc20 for bsc and coredao chains
Ticket: COIN-4135
1 parent 1ad0d90 commit 7dacd57

File tree

4 files changed

+31
-30
lines changed

4 files changed

+31
-30
lines changed

modules/statics/src/coinFeatures.ts

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -256,6 +256,19 @@ export const SOL_TOKEN_FEATURES_EXCLUDE_SINGAPORE = SOL_TOKEN_FEATURES.filter(
256256
);
257257
export const SOL_OFC_TOKEN_FEATURES = [...ACCOUNT_COIN_DEFAULT_FEATURES, CoinFeature.TSS, CoinFeature.TSS_COLD];
258258
export const APT_OFC_TOKEN_FEATURES = [...ACCOUNT_COIN_DEFAULT_FEATURES, CoinFeature.TSS, CoinFeature.TSS_COLD];
259+
260+
export const BSC_FEATURES = [
261+
...ETH_FEATURES_WITH_STAKING_AND_MMI,
262+
CoinFeature.TSS,
263+
CoinFeature.TSS_COLD,
264+
CoinFeature.EVM_WALLET,
265+
CoinFeature.MPCV2,
266+
CoinFeature.USES_NON_PACKED_ENCODING_FOR_TXDATA,
267+
CoinFeature.STUCK_TRANSACTION_MANAGEMENT_TSS,
268+
CoinFeature.CUSTODY_BITGO_FRANKFURT,
269+
CoinFeature.BULK_TRANSACTION,
270+
CoinFeature.ERC20_BULK_TRANSACTION,
271+
];
259272
export const BSC_TOKEN_FEATURES = [...ACCOUNT_COIN_DEFAULT_FEATURES, CoinFeature.BULK_TRANSACTION];
260273
export const BSC_TOKEN_FEATURES_EXCLUDE_SINGAPORE = [
261274
...ACCOUNT_COIN_DEFAULT_FEATURES_EXCLUDE_SINGAPORE,
@@ -489,6 +502,7 @@ export const COREDAO_FEATURES = [
489502
CoinFeature.EIP1559,
490503
CoinFeature.STAKING,
491504
CoinFeature.EIP1559,
505+
CoinFeature.ERC20_BULK_TRANSACTION,
492506
];
493507
export const APECHAIN_FEATURES = [
494508
...ETH_FEATURES,

modules/statics/src/coins.ts

Lines changed: 3 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ import {
8383
AVAXC_FEATURES,
8484
BERA_BGT_FEATURES,
8585
BERA_FEATURES,
86+
BSC_FEATURES,
8687
CELO_FEATURES,
8788
COREDAO_FEATURES,
8889
COREUM_FEATURES,
@@ -1134,17 +1135,7 @@ export const coins = CoinMap.fromCoins([
11341135
18,
11351136
UnderlyingAsset.BSC,
11361137
BaseUnit.BSC,
1137-
[
1138-
...ETH_FEATURES_WITH_STAKING_AND_MMI,
1139-
CoinFeature.TSS,
1140-
CoinFeature.TSS_COLD,
1141-
CoinFeature.EVM_WALLET,
1142-
CoinFeature.MPCV2,
1143-
CoinFeature.USES_NON_PACKED_ENCODING_FOR_TXDATA,
1144-
CoinFeature.STUCK_TRANSACTION_MANAGEMENT_TSS,
1145-
CoinFeature.CUSTODY_BITGO_FRANKFURT,
1146-
CoinFeature.BULK_TRANSACTION,
1147-
]
1138+
BSC_FEATURES
11481139
),
11491140
account(
11501141
'0a205427-f7c9-48a4-a238-c4b33ba6384d',
@@ -1154,17 +1145,7 @@ export const coins = CoinMap.fromCoins([
11541145
18,
11551146
UnderlyingAsset.BSC,
11561147
BaseUnit.BSC,
1157-
[
1158-
...ETH_FEATURES_WITH_STAKING_AND_MMI,
1159-
CoinFeature.TSS,
1160-
CoinFeature.TSS_COLD,
1161-
CoinFeature.EVM_WALLET,
1162-
CoinFeature.MPCV2,
1163-
CoinFeature.USES_NON_PACKED_ENCODING_FOR_TXDATA,
1164-
CoinFeature.STUCK_TRANSACTION_MANAGEMENT_TSS,
1165-
CoinFeature.CUSTODY_BITGO_FRANKFURT,
1166-
CoinFeature.BULK_TRANSACTION,
1167-
]
1148+
BSC_FEATURES
11681149
),
11691150
account(
11701151
'f0e226b6-6cd8-4384-b0a5-ba8e4148a049',

modules/statics/src/networks.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1273,8 +1273,6 @@ class CoredaoTestnet extends Testnet implements EthereumNetwork {
12731273
accountExplorerUrl = 'https://scan.test2.btcs.network/address/';
12741274
chainId = 1114;
12751275
nativeCoinOperationHashPrefix = '1114';
1276-
1277-
// TODO (SC-1024) Update contract addresses to new testnet when they are deployed
12781276
batcherContractAddress = '0x3e1e5d78e44f15593b3b61ed278f12c27f0ff33e';
12791277
forwarderFactoryAddress = '0x37996e762fa8b671869740c79eb33f625b3bf92a';
12801278
forwarderImplementationAddress = '0xd5fe1c1f216b775dfd30638fa7164d41321ef79b';

modules/statics/test/unit/coins.ts

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1035,17 +1035,25 @@ describe('Bulk Transaction Features', () => {
10351035

10361036
describe('ERC20 Bulk Transaction Feature', () => {
10371037
it('should have ERC20_BULK_TRANSACTION feature for appropriate coins', () => {
1038-
const erc20BulkTransactionCoins = ['eth', 'hteth', 'opeth', 'topeth', 'arbeth', 'tarbeth', 'polygon', 'tpolygon'];
1038+
const erc20BulkTransactionCoins = [
1039+
'eth',
1040+
'hteth',
1041+
'opeth',
1042+
'topeth',
1043+
'arbeth',
1044+
'tarbeth',
1045+
'polygon',
1046+
'tpolygon',
1047+
'coredao',
1048+
'tcoredao',
1049+
'bsc',
1050+
'tbsc',
1051+
];
10391052
erc20BulkTransactionCoins.forEach((coinName) => {
10401053
const coin = coins.get(coinName);
10411054
coin.features.includes(CoinFeature.ERC20_BULK_TRANSACTION).should.eql(true);
10421055
});
10431056
});
1044-
1045-
it('should not have ERC20_BULK_TRANSACTION feature for BSC', () => {
1046-
const coin = coins.get('bsc');
1047-
coin.features.includes(CoinFeature.ERC20_BULK_TRANSACTION).should.eql(false);
1048-
});
10491057
});
10501058

10511059
describe('Eip1559 coins', () => {

0 commit comments

Comments
 (0)