Nickez/rust port com label#1974
Open
NickeZ wants to merge 3 commits into
Open
Conversation
Move the label component implementation from C into the bitbox02 Rust crate while keeping the existing C ABI through label.h. Update bindgen inputs and build lists so firmware and unit-test builds link against the Rust symbols. Extend the UI component test coverage for label offsets and updates.
Avoid slicing strings inside a UTF-8 code point when truncating by byte length. This keeps callers that apply byte caps from panicking on multibyte input.
Truncate label text at a valid UTF-8 boundary before appending the ellipsis. Add tests for mid-codepoint and exact-boundary truncation.
NickeZ
force-pushed
the
nickez/rust-port-com-label
branch
from
2f73cb2 to
7fe785d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port the label component to rust so that it is easier to make it utf-8 safe.