[wip] Bb03 unlock anim#1943
Draft
benma wants to merge 3 commits into
Draft
Conversation
Before the securechip operations became async, the UI did not process during keystore unlock and froze at the last screen of the password confirmation, and UI continued with the BIP39 unlock animation. Now that they are async, the password screen is popped and the waiting screen would be shown for roughly 1s before the unlock animation started. To improve UI there, we start showing first screen of the unlock animation (the locked lock) as the filler screen. Instead of the default waiting screen being shown, during these operations the first animation frame component is shown and held, with animation starting only in bip39_unlock. The downside is that when entering the wrong password, it is also briefly shown before the wrong-password error message, but it's acceptable. There are other workflows where the waiting screen is also shown during the stretch, not addresed by this commit: show mnemonic, create backup, and change password (any call to `workflows::unlock::unlock_keystore()` to check the password). Co-Authored-By: Niklas Dusenlund <niklas.dusenlund@bitbox.swiss>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase once #1942 is merged.