Skip to content

backend: extract account derivation specs#4158

Open
benma wants to merge 1 commit into
BitBoxSwiss:masterfrom
benma:derivation-spec
Open

backend: extract account derivation specs#4158
benma wants to merge 1 commit into
BitBoxSwiss:masterfrom
benma:derivation-spec

Conversation

@benma
Copy link
Copy Markdown
Contributor

@benma benma commented May 19, 2026

No description provided.

@benma benma requested a review from strmci May 19, 2026 14:40
@benma benma requested a review from a team as a code owner May 19, 2026 14:40
Copy link
Copy Markdown
Collaborator

@strmci strmci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: consider renaming BIP44CoinType to HardenedBIP44CoinType. It returns the hardened keypath element rather than the SLIP-44 coin type.

Besides that LGTM.

@benma benma force-pushed the derivation-spec branch from 80ea383 to a9ed550 Compare May 19, 2026 20:54
@benma
Copy link
Copy Markdown
Contributor Author

benma commented May 19, 2026

nit: consider renaming BIP44CoinType to HardenedBIP44CoinType. It returns the hardened keypath element rather than the SLIP-44 coin type.

Besides that LGTM.

Good point. I changed the map to define the unhardened numbers instead. Please check.

@benma benma requested a review from strmci May 19, 2026 20:54
Copy link
Copy Markdown
Collaborator

@strmci strmci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants