frontend: build frontend with npm ci --ignore-scripts#4157
Open
thisconnect wants to merge 1 commit into
Open
Conversation
The web fronternd and all its dependencies should work without postintall hook, this may reduce some evil scripts in npm deps from executing malicious code at install time. Most important make tasks such as webdev, webbuild, weblint and webtest all seem to work and not require running any postinstall npm hooks.
thisconnect
commented
May 19, 2026
| - name: Install dependencies | ||
| working-directory: frontends/mobiletests | ||
| run: npm ci | ||
| run: npm ci --ignore-scripts |
Collaborator
Author
There was a problem hiding this comment.
oups, I wasn't planning to add ignore-scripts to the mobiletests install dependencies step.
but CI seems happy, keeping it here for now.
I didn't check all deps, but the explicit android-e2e test has appium which has a postinstall hook.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The web fronternd and all its dependencies should work without postintall hook, this may reduce some evil scripts in npm deps from executing malicious code at install time.
Most important make tasks such as webdev, webbuild, weblint and webtest all seem to work and not require running any postinstall npm hooks.
Before asking for reviews, here is a check list of the most common things you might need to consider: