Skip to content

ci: bump Node.js from 20 to 24 LTS#4147

Open
smokyisthatyou wants to merge 1 commit into
BitBoxSwiss:masterfrom
smokyisthatyou:node-24
Open

ci: bump Node.js from 20 to 24 LTS#4147
smokyisthatyou wants to merge 1 commit into
BitBoxSwiss:masterfrom
smokyisthatyou:node-24

Conversation

@smokyisthatyou
Copy link
Copy Markdown
Contributor

Update CI, Docker image (v37), docs, and package.json engines. Depends on #4115 for Node 24 locale test fixes; container image must be rebuilt before container jobs pass.

Before asking for reviews, here is a check list of the most common things you might need to consider:

  • updating the Changelog
  • writing unit tests
  • checking if your changes affect other coins or tokens in unintended ways
  • testing on multiple environments (Qt, Android, ...)
  • having an AI review your changes

@smokyisthatyou smokyisthatyou requested a review from a team as a code owner May 14, 2026 09:55
@thisconnect thisconnect requested a review from Beerosagos May 18, 2026 06:51
Copy link
Copy Markdown
Collaborator

@Beerosagos Beerosagos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed the new image, please remove the last commit :)

Comment thread README.md Outdated
- [Go](https://golang.org/doc/install) version 1.26
- [Node.js](https://nodejs.org/) version 20.x
- [Node.js](https://nodejs.org/) version 24.x
- [NPM](https://docs.npmjs.com/about-npm-versions) version 10.x or newer
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NPM 11 here, I guess?

Update CI, Docker image (v37), docs, and package.json engines.
Depends on BitBoxSwiss#4115 for Node 24 locale test fixes.
@smokyisthatyou
Copy link
Copy Markdown
Contributor Author

@Beerosagos updated the readme and removed last commit, ptal :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants