frontend: sync account details with recv addr type#4125
Conversation
Default the Bitcoin account details view to the persisted receive script type instead of always showing the first signing configuration. This makes accounts configured to receive on Taproot open Account details on Taproot information by default, while preserving the existing toggle between available signing configurations.
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR adds logic to Bitcoin's account detail view to display the XPUB matching the persisted receive address script type by default. A new helper function maps the account's ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
||
| const showNextXPub = () => { | ||
| setViewXPub(prev => (prev + 1) % numberOfXPubs); | ||
| setViewXPub((safeViewXPub + 1) % numberOfXPubs); |
There was a problem hiding this comment.
nit: Probably fine, but in theory (if somebody clicks very fast 😅) the previous version was concurrency-safe and always based on latest state.
Default the Bitcoin account details view to the persisted receive script type instead of always showing the first signing configuration.
This makes accounts configured to receive on Taproot open Account details on Taproot information by default, while preserving the existing toggle between available signing configurations.
Before asking for reviews, here is a check list of the most common things you might need to consider: