Skip to content

WIP: Update translations#3940

Closed
jstrnbrg wants to merge 0 commit intomasterfrom
master
Closed

WIP: Update translations#3940
jstrnbrg wants to merge 0 commit intomasterfrom
master

Conversation

@jstrnbrg
Copy link
Copy Markdown
Collaborator

No description provided.

@jstrnbrg jstrnbrg requested a review from thisconnect March 20, 2026 06:59
Comment thread frontends/web/src/locales/de/app.json
Comment thread frontends/web/src/locales/de/app.json Outdated
Comment thread frontends/web/src/locales/de/app.json
"tooLarge": "Datei zu groß.",
"transactionNotes_one": "{{count}} Transaktionsnotiz importiert.",
"transactionNotes_other": "{{count}} Transaktionsnotizen importiert.",
"transactionNotes_zero": "0 Transaktionsnotizen importiert."
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the DE translation of transactionNotes_zero?

current master has it in EN and DE, we should keep the DE one.

"transactionNotes_zero": "Imported 0 transaction notes."

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically Weblate follows CLDR (Common Locale Data Repository) stricly and for EN & DE there are only two forms. _one and _other which is why _zero gets removed. But that should be fine right? Using other with 0 still makes sense "{{count}} Transaktionsnotizen importiert."

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack. Also found related weblate issue: WeblateOrg/weblate#9358

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something to test is that where there is pluralization i.e. _many in ES or _few in CS, it will add empty string. We should test that it still fallsback to EN in case those are not translated.
(ideally of course they all get a translation)

Comment thread frontends/web/src/locales/de/app.json
Comment thread frontends/web/src/locales/de/app.json Outdated
"titleDisabled": "Bluetooth aktvieren",
"titleEnabled": "Bluetooth deaktivieren"
"titleEnabled": "Bluetooth deaktivieren",
"error_104": "Änderung der Bluetooth-Einstellungen wurde abgebrochen."
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not alphabetically sorted, that is probably the reason why lint fails in CI

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI uses locize formatting, but since we don't use locize anymore, maybe that should be changed?

Though alphabetical makes sense regardless I think. @jstrnbrg can weblate be configured like this?

@jstrnbrg
Copy link
Copy Markdown
Collaborator Author

There is a weblate add-on to squash all commits into one instead of one per lang. What do you prefer? @benma @thisconnect

@thisconnect
Copy link
Copy Markdown
Collaborator

There is a weblate add-on to squash all commits into one instead of one per lang. What do you prefer?

I don't mind a commit per langauge + 1 optional cleanup. But no strong opinion.

@jstrnbrg
Copy link
Copy Markdown
Collaborator Author

There is a weblate add-on to squash all commits into one instead of one per lang. What do you prefer?

I don't mind a commit per langauge + 1 optional cleanup. But no strong opinion.

If we ever need to revert a weblate merge, reverting one commit would be easier than 20x

@jstrnbrg
Copy link
Copy Markdown
Collaborator Author

Superseded by #3949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants