frontend: revamp account summary data / table#3898
Merged
shonsirsha merged 7 commits intoBitBoxSwiss:masterfrom Mar 30, 2026
Merged
frontend: revamp account summary data / table#3898shonsirsha merged 7 commits intoBitBoxSwiss:masterfrom
shonsirsha merged 7 commits intoBitBoxSwiss:masterfrom
Conversation
shonsirsha
force-pushed
the
frontend-revamp-portfolio-table
branch
from
99cd4ee to
ae773f6
Compare
shonsirsha
changed the title
shonsirsha
force-pushed
the
frontend-revamp-portfolio-table
branch
from
ae773f6 to
8a4e421
Compare
shonsirsha
commented
Mar 4, 2026
shonsirsha
force-pushed
the
frontend-revamp-portfolio-table
branch
from
8a4e421 to
4e8af54
Compare
shonsirsha
commented
Mar 4, 2026
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
thisconnect
requested changes
Mar 9, 2026
shonsirsha
force-pushed
the
frontend-revamp-portfolio-table
branch
2 times, most recently
from
1836b6c to
d013276
Compare
shonsirsha
force-pushed
the
frontend-revamp-portfolio-table
branch
from
d013276 to
adcf6f7
Compare
shonsirsha
force-pushed
the
frontend-revamp-portfolio-table
branch
3 times, most recently
from
0ac2482 to
72d61f7
Compare
thisconnect
requested changes
Mar 12, 2026
shonsirsha
force-pushed
the
frontend-revamp-portfolio-table
branch
2 times, most recently
from
6f89572 to
677278a
Compare
thisconnect
requested changes
Mar 17, 2026
shonsirsha
force-pushed
the
frontend-revamp-portfolio-table
branch
2 times, most recently
from
fd08e70 to
3f88840
Compare
shonsirsha
force-pushed
the
frontend-revamp-portfolio-table
branch
from
3f88840 to
60bf8c1
Compare
shonsirsha
force-pushed
the
frontend-revamp-portfolio-table
branch
2 times, most recently
from
f3ace61 to
dee75ce
Compare
shonsirsha
force-pushed
the
frontend-revamp-portfolio-table
branch
from
dee75ce to
d06432b
Compare
thisconnect
requested changes
Mar 30, 2026
Collaborator
thisconnect
left a comment
thisconnect
left a comment
There was a problem hiding this comment.
very nice, code LGTM with tiny nit
thisconnect
force-pushed
the
frontend-revamp-portfolio-table
branch
from
de6009a to
3bef7b0
Compare
thisconnect
approved these changes
Mar 30, 2026
Collaborator
thisconnect
left a comment
thisconnect
left a comment
There was a problem hiding this comment.
LGTM, the only point from my side is to consider making the coin and fiat unit on the right side smaller as well.. wrote in dm..
- success flag not needed - can reuse existing functions - remove second CoinFiatPrices function
Before it would show false because 1 sat converted to fiat is rounded to 0.
shonsirsha
force-pushed
the
frontend-revamp-portfolio-table
branch
from
3bef7b0 to
02233db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revamp account summary data / table: