Serialize BitBox API calls#124
Conversation
NickeZ
left a comment
There was a problem hiding this comment.
Did you consider having a single task for communication and using channels instead?
The benefit of using a dedicated task that serializes the requests is that the serialization is enforced by the compiler.
No strong opinion though, it just seems like a better pattern to me.
Tomasvrba
left a comment
There was a problem hiding this comment.
ack, nice improvement
Only briefly, but I avoided it because it would be a much larger and more invasive change 🤔 Note that the device communication is not (only) the thing that needs to be serialized, but the high level methods like btcSignTx and btcSignMsg need to be serialized - they perform multiple device queries that can't be interleaved. |
No description provided.