CPack ODBC Windows msi installer #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alinaliBQ
force-pushed
the
cpack-installer-win
branch
from
41ec0a0 to
aba8211
Compare
Running `cpack` with NSIS installed creates an installer, but the installer misses dll dependencies.
alinaliBQ
force-pushed
the
cpack-installer-win
branch
2 times, most recently
from
6f03303 to
b42468a
Compare
Trying to find the path to release/Release folder
alinaliBQ
force-pushed
the
cpack-installer-win
branch
from
b42468a to
0f55e31
Compare
alinaliBQ
force-pushed
the
cpack-installer-win
branch
from
0f55e31 to
0cad6f4
Compare
alinaliBQ
force-pushed
the
cpack-installer-win
branch
from
9e30026 to
23e8f30
Compare
This reverts commit 23e8f30.
alinaliBQ
commented
Aug 18, 2025
This doesn't work as expected
* Do not use cpack, since cpack brings in unwanted files from `install` commands
Initial nsis installer file
This reverts commit 3a0f9ba.
Closed
* By default, if `CPACK_GENERATOR` is not set, `NSIS` is used
alinaliBQ
changed the title
alinaliBQ
changed the title
rscales
approved these changes
Aug 20, 2025
justing-bq
approved these changes
Aug 20, 2025
justing-bq
left a comment
justing-bq
left a comment
There was a problem hiding this comment.
I assume all these commits will be squashed into one?
Author
Yes, that is right. We will use "squash and merge" feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Develop Windows ODBC installer using CPack since it will work well with macOS and Linux.
Add
ARROW_FLIGHT_SQL_ODBC_INSTALLERenvironment variable to enable creation of Windows installer