Skip to content

Connection code clean up#3

Open
stevenzhang717 wants to merge 3 commits into
masterfrom
connection_code_clean_up
Open

Connection code clean up#3
stevenzhang717 wants to merge 3 commits into
masterfrom
connection_code_clean_up

Conversation

@stevenzhang717

Copy link
Copy Markdown
Collaborator
  • clean up your connection code, you don't need to return a function, just return the object, if you import your module somewhere else, those object could be reuse
  • extracted database creation script
    -add creation script to connection.js, please test if it works with your migration process.

@stevenzhang717 stevenzhang717 requested a review from JasonShin June 7, 2017 13:17
@stevenzhang717

Copy link
Copy Markdown
Collaborator Author

you might want to check if the my db code could work with your db migration code, when i ran the first time, it had some transaction issue.

@JasonShin

Copy link
Copy Markdown
Member

It doesn't contain connection code clean up. And could you please remove sql file since it won't be used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants