Fix BASISU_ZSTD=OFF #427
Open
Fix BASISU_ZSTD=OFF #427
+67
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks - the Zstd local vs. system problem is the next thing we're addressing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes support for
-DBASISU_ZSTD=OFF, which is useful for projects where assets already have compression applied to them to avoid redundancy (or in web deployments where server typically compresses binary files already). This was broken it seems withbasisu_astc_ldr_encode.cppunconditionally including zstd where previously only KTX2 code paths conditionally included it.Also treat zstd as a separate libraries (encoder and decoder-only variants) with its own include path vs hard-coded relative path. This makes it easier for dependent projects to use their own version of zstd to avoids conflicts.