Clean up of errors when query parameters change in the fg_pitcher_leaders function#398
Open
tmr621 wants to merge 2 commits into
Open
Clean up of errors when query parameters change in the fg_pitcher_leaders function#398tmr621 wants to merge 2 commits into
tmr621 wants to merge 2 commits into
Conversation
tmr621
commented
Apr 3, 2026
tmr621
commented
- Swapped season parameters to match the Fangraphs API string. Was reversed previously, which caused errors for multiseason queries.
- Added proper capitalization of Season variable.
- Added logic in column renaming as to not error when a column isn't present. This occurred when querying as starting pitchers only OR when querying as reliever only (stats = "str" or stats = "rel")
- swapped season parameters to match the Fangraphs API string. Was reversed previously, which caused errors for multiseason queries. - Added proper capitalization of Season variable. - Added logic in column renaming as to not error when a column isn't present. This occurred when querying as starting pitchers only OR when querying as reliever only (stats = "str" or stats = "rel"
Clean up of errors when query parameters change in the fg_pitcher_leaders function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.