Add a results api that gives back the winner#5
Open
arthurmelton wants to merge 1 commit intoBigBoot:masterfrom
Open
Add a results api that gives back the winner#5arthurmelton wants to merge 1 commit intoBigBoot:masterfrom
arthurmelton wants to merge 1 commit intoBigBoot:masterfrom
Conversation
Author
|
I also though I posted this but just for reference this is for BigBoot/fang#18 |
arthurmelton
pushed a commit
to arthurmelton/fang
that referenced
this pull request
May 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an api endpoint at
/api/resultthat currently only gives back the winning team. This implements a feature where once a game is done it will allow getting the results for 5 minuets or until a new game is started on that port. This should give time for people to pressGGin fang while not being being too long for another game to accidentally go on. I also made this the endpointresultand notwinnerbecause some other data might want to be sent back (Like some automated tests or a simple anticheat, that would help automate admins having to look through the logs if they could just get all the info instantly).