Skip to content

Conversation

@yulric
Copy link
Contributor

@yulric yulric commented Jan 16, 2026

No description provided.

Copy link
Collaborator

@rafdoodle rafdoodle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEN_132 available in 2007-2008 (4.1) as DEN_132 (what you currently have), and in both 2015-2016 and 2017-2018 as DEN_035 (Visited dental professional - last time).

@yulric
Copy link
Contributor Author

yulric commented Jan 19, 2026

DEN_132 available in 2007-2008 (4.1) as DEN_132 (what you currently have), and in both 2015-2016 and 2017-2018 as DEN_035 (Visited dental professional - last time).

Is this for the master file cycles?

@rafdoodle
Copy link
Collaborator

rafdoodle commented Jan 19, 2026

DEN_132 available in 2007-2008 (4.1) as DEN_132 (what you currently have), and in both 2015-2016 and 2017-2018 as DEN_035 (Visited dental professional - last time).

Is this for the master file cycles?

Yes!

@DougManuel
Copy link
Contributor

Review summary

Reviewed DEN_132 worksheet with PUMF integration testing. The current configuration is correct for the cycles included, but we found additional cycles available.

Verified from actual PUMF data

Ran integration tests across all CCHS PUMF cycles:

Cycle Variable National % Valid
2001 DENA_132 35.7% ✓
2003 DENC_132 58.6% ✓
2005 DENE_132 33.5% ✓
2007-2008 DEN_132 10.1% ✓
2009-2010 DEN_132 34.1% ✓
2011-2012 DEN_132 14.7% ✓
2013-2014 DEN_132 28.9% ✓
2015-2016 DEN_035 13.9% ✓
2017-2018 DEN_035 27.4% ✓
2019-2020 Not collected
2022 Not collected

Key findings

  1. Variable renamed: DEN_132 → DEN_035 starting in 2015-2016 (confirmed in PUMF DDI)
  2. Additional cycles available: 2007-2008, 2015-2016, 2017-2018 exist in PUMF
  3. Optional Content: Dental module was Optional Content in some cycles, so provincial response rates vary

Current PR scope

The cycles in this PR (2001, 2003, 2005, 2009-2010, 2011-2012, 2013-2014) are confirmed. Source variable naming (DENA_132, DENC_132, DENE_132, DEN_132) is correct.

Questions

  1. Should we expand to include 2007-2008, 2015-2016, and 2017-2018 in this PR or a follow-up?
  2. If adding 2015-2018, need to verify DEN_035 category values match DEN_132
  3. Should we add a note about Optional Content status to the variable description?

Verified DEN_132/DEN_035 availability across CCHS cycles using
rec_with_table() integration tests on actual PUMF data. Found:
- Variable renamed DEN_132 to DEN_035 in 2015-2016
- Additional cycles available: 2007-2008, 2015-2016, 2017-2018
- Ontario excluded in 2007-2008, 2011-2012, 2015-2016 (Optional Content)

PR #158 review posted with recommendations to expand scope.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants