Skip to content

Conversation

@Correct-Syntax
Copy link
Member

@Correct-Syntax Correct-Syntax commented Jul 5, 2024

This is a quick, wide-scope PR that fixes some bugs and updates the application version and copyright year.

Additionally, it fixes some verses in the verses json text and adds some chapters and verses.

@Correct-Syntax Correct-Syntax requested a review from iwoithe July 5, 2024 15:01
@Correct-Syntax
Copy link
Member Author

@iwoithe does this look good to merge? 😃

Copy link
Member

@iwoithe iwoithe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 LGTM 👍

# NOTE: This *has* to be QGuiApplication otherwise the system tray right-click menu won't show
app = QGuiApplication(sys.argv)

QQuickStyle.setStyle("Basic")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to add a comment above this line of why it's there (mostly as I'll probably forget otherwise haha). I'll open a PR within a week unless ofc you beat me to it 😉

Details

https://forum.qt.io/topic/145229/qt-6-5-the-current-style-does-not-support-customization-of-this-control

https://stackoverflow.com/questions/76625756/the-current-style-does-not-support-customization-of-this-control

@iwoithe iwoithe merged commit f943404 into BibleNotify:master Dec 25, 2024
3 checks passed
@iwoithe
Copy link
Member

iwoithe commented Dec 25, 2024

Thanks @Correct-Syntax! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants