[184] Landing page#131
Open
BhuvanArn wants to merge 19 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
🚅 Deployed to the TalkUp.AI-pr-131 environment in talk-up-ai
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a dedicated marketing/landing experience to the web app, including a public-shell layout for landing + auth-related pages and a redirect that sends authenticated users into the app.
Changes:
- Replaces the
/route with a newLandingPageand redirects authenticated users from/to/simulations. - Introduces a shared
AuthPageShellfor auth flows and updates the root layout to hide the app sidebar on landing/auth routes. - Adds Playwright e2e coverage for landing/auth shell rendering plus unit tests for the new auth redirect guard and
AuthPageShell.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
| web/tests/landing.spec.ts | New Playwright e2e assertions for landing + auth-page shell behavior (nav/logo links, no sidebar). |
| web/src/utils/auth.guards.ts | Adds createAuthRedirectGuard used to redirect authenticated users away from public pages (landing). |
| web/src/utils/auth.guards.spec.ts | Unit tests for createAuthRedirectGuard. |
| web/src/services/axiosInstance.ts | Adds / to the “no login redirect after refresh fail” allowlist for public routes. |
| web/src/routes/index.tsx | Replaces the old home content with LandingPage and adds beforeLoad auth redirect. |
| web/src/routes/__root.tsx | Adds “public shell” routing logic to omit the app sidebar on landing/auth pages and optionally show landing nav. |
| web/src/routes/login.tsx | Wraps login form in AuthPageShell for consistent auth layout. |
| web/src/routes/register.tsx | Wraps register form in AuthPageShell for consistent auth layout. |
| web/src/routes/forgot-password.tsx | Wraps forgot-password form in AuthPageShell for consistent auth layout. |
| web/src/routes/reset-password.tsx | Wraps reset-password form in AuthPageShell for consistent auth layout. |
| web/src/routes/verify-email.tsx | Wraps verify-email form in AuthPageShell for consistent auth layout. |
| web/src/components/organisms/landing-page/index.tsx | New landing page implementation (hero, features, pricing, testimonials, CTA). |
| web/src/components/organisms/landing-nav/index.tsx | New landing navigation (desktop + mobile). |
| web/src/components/organisms/landing-footer/index.tsx | New landing footer with product/company/legal columns and social links. |
| web/src/components/molecules/auth-page-shell/index.tsx | New shared auth-page shell providing “back to home” and logo link. |
| web/src/components/molecules/auth-page-shell/index.spec.tsx | Unit tests for AuthPageShell. |
| CONTRIBUTING.MD | Updates contribution workflow documentation (issues/branch naming/PR process/CI expectations). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
15
to
25
| circled?: boolean; | ||
| asChild?: boolean; | ||
| children?: React.ReactNode; | ||
| } |
Comment on lines
+47
to
+56
| <ul className="hidden items-center gap-8 lg:flex"> | ||
| {NAV_LINKS.map((link) => ( | ||
| <li key={link.hash}> | ||
| <a | ||
| href={buildHref(link.hash)} | ||
| className="text-body-m text-text-weak hover:text-accent transition-colors" | ||
| > | ||
| {link.label} | ||
| </a> | ||
| </li> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Adds the marketing landing page at
/and reshapes the public shell so authenticated and unauthenticated users see the right chrome on each route.Highlights
landing-page,landing-nav,landing-footerorganisms)./login,/register,/forgot-password,/reset-password,/verify-email).auth-page-shellmolecule: TalkUp logo centered with the form, "Back to home" link top-left./redirects authenticated users to/simulationsvia a newcreateAuthRedirectGuardhelper, while still rendering the landing page for anonymous visitors./aboutrenders the landing nav for anonymous users and the app shell (sidebar) for authenticated users./after a failed token refresh (added/to the no-redirect set so the landing page renders cleanly).CONTRIBUTING.MDto reflect the GitHub Project + Issues workflow (no more Trello/Kanban references) and thestagingbase branch.auth-page-shellandcreateAuthRedirectGuard, plus Playwright e2e coverage for the landing page and auth shells.Linked GitHub Ticket
Closes EpitechPromo2027/G-EIP-600-NAN-6-1-eip-tugdual.de-reviers#184
Workspace
Screenshots
Landing page (
/)Login (
/login)Register (
/register)About page for anonymous users (
/about)