Skip to content

Add header images when available to general and news feeds#30

Open
bgtripp wants to merge 10 commits intoBhupesh-V:masterfrom
bgtripp:add-header-images
Open

Add header images when available to general and news feeds#30
bgtripp wants to merge 10 commits intoBhupesh-V:masterfrom
bgtripp:add-header-images

Conversation

@bgtripp
Copy link
Copy Markdown

@bgtripp bgtripp commented Nov 14, 2020

Changes

  • Added function to find image url from feedparser dictionary objects
  • Used said function to assign value of "image" key for items in the general and news feeds
  • Adjusted template to allow for display of header images if they are found
  • Added custom css to display images properly

@bgtripp bgtripp closed this Nov 14, 2020
@bgtripp bgtripp reopened this Nov 14, 2020
@sonarqubecloud
Copy link
Copy Markdown

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
34.1% 34.1% Duplication

@bgtripp
Copy link
Copy Markdown
Author

bgtripp commented Nov 14, 2020

Sorry for closing and reopening, I'm new to working on open source projects! It seems like these checks are failing from pre-existing code in the project. Also, that duplication rule is a little strict when that one block copied between two templates is a third of my new lines haha. Let me know if you need me to edit it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant