[fix] Thread callback ordering #53
Merged
+141
−115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Betterment#42 inadvertently flipped the order of `:thread` and `:perform`, and also pushed `:thread` far enough in that cleanup steps would happen after the `with_connection`'s `end` block in the connection plugin. This introduces the possibility of thread safety issues, or connections being held longer than intended (exhausting the connection pool / connection limits).
smudge
commented
Apr 2, 2025
| pool = Concurrent::FixedThreadPool.new(jobs.length) | ||
| jobs.each do |job| | ||
| pool.post do | ||
| success.increment if run_job(job) |
Member
Author
There was a problem hiding this comment.
If you notice, run_job actually triggers the :perform callbacks before calling run, which triggers :thread.
This was never intended, and to reduce confusion, more callbacks have been fully inlined, and the methods have been reduced to a single perform(job) method.
smudge
added a commit
to smudge/delayed
that referenced
this pull request
Apr 3, 2025
smudge
added a commit
to smudge/delayed
that referenced
this pull request
Apr 3, 2025
smudge
added a commit
that referenced
this pull request
Apr 3, 2025
I'm adding regression coverage for the changes made in #53, and making one additional change in line with the way that the `:perform` callback [works in the `delayed_job` gem](https://github.com/collectiveidea/delayed_job/blob/ea4879dd3c2f3f5aa7f616a6f0fd58f2bbc2a481/lib/delayed/worker.rb#L313) - there is also now a test that will more explicitly check the order of callback events and behavior on job failure. Plus, while debugging in an app, I noticed that datadog tries to cast priority to a float, which was raising a method undefined error. So I added `Delayed::Priority#to_f` and added a test to cover all the explicit conversion methods (`to_s`, `to_i`, `to_f`, `to_d`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/no-platform
/domain @argvniyx-enroute @mavenraven
PR #42 inadvertently flipped the order of
:threadand:perform, and also pushed:threadfar enough in that cleanup steps would happen after thewith_connection'sendblock in the connection plugin.This introduces the possibility of thread safety issues, or connections being held longer than intended (exhausting the connection pool / connection limits).