Remove hiring CTA from blog posts; pad announcement banner#159
Draft
mateo-berri wants to merge 1 commit into
Draft
Remove hiring CTA from blog posts; pad announcement banner#159mateo-berri wants to merge 1 commit into
mateo-berri wants to merge 1 commit into
Conversation
- Drop the 'We're hiring / Like what you see? Join us' card from the bottom of every blog post. The blog list page hero already has a 'We're hiring!' button, so this avoids duplicating the link in a noisy footer card on every post. - Move announcement bar padding onto the inner content div and bump it to 14px vertical / 48px horizontal (12/20 on mobile) so the May Town Hall banner no longer sits flush against the viewport edges. Co-authored-by: Mateo Wang <mateo-berri@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small docs UI fixes:
src/theme/BlogPostPage/index.js. It looked out of place stuck under each post, and the blog list page hero already has a "We're hiring!" button, so the link is still discoverable in a better spot.padding: 10px 0on the outer bar, leaving the text flush against the left/right viewport edges. Padding now lives on the inner content div at14px 48px(12px 20pxon mobile) so the banner has proper breathing room.Files changed
src/theme/BlogPostPage/index.js— dropHiringCTAcomponent and its render.src/theme/BlogPostPage/styles.module.css— remove now-unused.cta*styles.src/css/custom.css— pad the announcement bar's content div, drop the outerpadding: 10px 0.Testing
Visual change only; no logic affected. Couldn't run a local docusaurus build (
node_modulesnot installed in this environment), but the diff is purely CSS + removal of a static React component.Slack Thread