using ruby3.3-slim for image, updated README, using app name for serv… #3
+52
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danschmidt5189
requested changes
Jan 13, 2026
Member
danschmidt5189
left a comment
danschmidt5189
left a comment
There was a problem hiding this comment.
Looks good, but I'd like to take the opportunity to optimize this Docker build using our usual multi-target setup. See my link and comments for details and let me know if you have any Q's.
danschmidt5189
requested changes
Jan 14, 2026
Member
danschmidt5189
left a comment
danschmidt5189
left a comment
There was a problem hiding this comment.
Two final requests:
- Looks like we're duplicating the CMD and ENTRYPOINT directives, so those should probably be moved to
base. - GitHub Actions flagged a bunch of minor formatting issues for the Dockerfile related to directive casing (e.g. from -> FROM). Let's just be consistent with those.
Besides that looks good! Thanks for going the extra mile here.
…ice instead of bfs now took out some unnecessary installs in Dockerfile, updated README using multi-target for images set working directory for production docker build Adding entrypoint to production build moved some common dev and production settings to base in Dockerfile, fixed some annotation warning
davezuckerman
force-pushed
the
AP-552-update-ruby-base
branch
from
853541c to
c2b9d89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ice instead of bfs now