js: Use the aria-pressed attribute on fullscreen
#31
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the `aria-pressed` attribute for the fullscreen button. The value toggles in the enterFullScreen/exitFullScreen methods. Notably, the value is always `false` in Safari / iOS WebKit. This is because the WebKit's native fullscreen view disable access to the DOM and all elements. There is no way to interact or manipulate them from the fullscreen view. This should be fine, because that means any time the user can interact with them, the pressed value should be false. Closes: ADA-674
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
aria-pressedattribute for the fullscreen button. The value toggles in the enterFullScreen/exitFullScreen methods.Notably, the value is always
falsein Safari / iOS WebKit. This is because the WebKit's native fullscreen view disable access to the DOM and all elements. There is no way to interact or manipulate them from the fullscreen view. This should be fine, because that means any time the user can interact with them, the pressed value should be false.Closes: ADA-674