Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes JLC electrolytic capacitor parsing to handle dots in dimensions and support smaller 6.3x7.7mm packages. The fix updates the regex pattern to avoid matching dimension specifications that are part of longer numeric strings, and regenerates reference netlists with the newly parsed smaller capacitors.
- Updated regex pattern in
JlcAluminumCapacitorto properly parse dimensions with dots - Replaced larger 8x10mm capacitors with smaller 6.3x7.7mm variants in example projects
- Regenerated coordinate data and netlists for affected example boards
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| edg/parts/JlcElectrolyticCapacitor.py | Modified regex to add negative lookahead for digit/dot before dimensions |
| examples/UsbSourceMeasure/UsbSourceMeasure.svgpcb.js | Updated component positions and changed C1 footprint from CP_Elec_8x10 to CP_Elec_6_3x7_7 |
| examples/UsbSourceMeasure/UsbSourceMeasure.net | Updated C1 footprint and part metadata to reflect new 6.3x7.7mm capacitor |
| examples/IotRollerBlinds/IotRollerBlinds.svgpcb.js | Updated component positions and changed BC10 footprint from CP_Elec_8x10 to CP_Elec_6_3x7_7 |
| examples/IotRollerBlinds/IotRollerBlinds.net | Updated BC10 footprint and part metadata to reflect new 6.3x7.7mm capacitor |
| examples/IotCurtainCrawler/IotCurtainCrawler.svgpcb.js | Updated component positions and changed RC14 footprint from CP_Elec_8x10 to CP_Elec_6_3x7_7 |
| examples/IotCurtainCrawler/IotCurtainCrawler.net | Updated RC14 footprint and part metadata to reflect new 6.3x7.7mm capacitor |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes cases where there is a dot in the dimensions and allows smaller 6.3x7.7mm caps to be parsed.
... and rebaseline the reference netlists