feat: add getthumbslinks client method#16
Merged
Merged
Conversation
Adds the JSON batch counterpart to getthumblink — accepts a list of fileids and returns a ThumbResult[] of assembled thumbnail URLs. Per-file failures (non-zero per-file result, or empty hosts) are silently dropped, mirroring getthumbsfileids' behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
client.getthumbslinks(fileids, options?)— the JSON batch counterpart togetthumblink. Accepts an array offileidsand returnsThumbResult[]of assembled thumbnail URLs in a single round-trip.ThumbOptionsandThumbResulttypes; defaults matchgetthumblink(type='auto',size='120x120',crop=true).result, or emptyhosts) are silently dropped — mirrors howgetthumbsfileidstreats failed entries.Test plan
pnpm type-check— strict TS passespnpm test:unit— all 67 unit tests pass (6 new forgetthumbslinks)pnpm format:check— formatting cleanpnpm lint— no lint errors on changed filespnpm build—dist/index.d.tsexposes the newgetthumbslinks(fileids, options?)signature