Skip to content

Fix an auctionid_str typo in a comment #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blandrum-fw wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix an auctionid_str typo in a comment #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion beeswax/logs/streaming/ad_log.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ message ImpressionLogMessage {
// There can be multiple impression definitions in a single bid request from the
// inventory source; each one Beeswax actually bids on creates a unique auctionid.
optional base.EventId auctionid = 1;
// NOTE: auction_id_str is an opaque unique id. Clients should not rely on the meaning
// NOTE: auctionid_str is an opaque unique id. Clients should not rely on the meaning
// of elements within it or on the format of the id.
optional string auctionid_str = 12;
// The unique identifier of the bid request per buzz_key. This represents a BidRequest
Expand Down