Skip to content
This repository was archived by the owner on Jul 11, 2024. It is now read-only.

Conversation

@rpowis
Copy link

@rpowis rpowis commented Feb 17, 2017

What problem does this PR solve?

After updating Jenkins to versions after 1.576, the selectors in the CSS of this plugin weren't targeting the new UI's console pane.

The Jenkins UI was refreshed in this release as per the announcement on their blog, and with it, some of the class names and ids changed in the markup.

This plugin's great, and I got so used to seeing Jenkins console logs in Solarized Dark that when we updated to 1.576 I found it a quite jarring.

image

Solution

  • Add the new selectors (rather than replace the old ones) for backwards compatibility
  • Switch the left and right margins with padding to give the text some room to breath and make it easier to read

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant