Moved to vite, fixed some bugs and broken links#22
Open
KalmeMarq wants to merge 5 commits intoBedrockLauncher:mainfrom
Open
Moved to vite, fixed some bugs and broken links#22KalmeMarq wants to merge 5 commits intoBedrockLauncher:mainfrom
KalmeMarq wants to merge 5 commits intoBedrockLauncher:mainfrom
Conversation
The create-react-app (webpack) is old and slow so I moved to vite which faster and simpler. Updated dependencies and removed unused ones. Fixed the '0' appearing on the search boxes when they are empty or there are 0 results. Fixed the side navbar top being cut off. Made the credits card use the drop-shadow filter so when the pic isn't a full square it casts correctly around the pic. Improved the layout style of release accordions markdown. Moved the pagination (used in Releases) to its on file.
Member
|
Is this finalized, @KalmeMarq? |
Contributor
Author
|
no, I'll see if I can do a little more |
Member
|
Code review is gonna be fun... |
Contributor
Author
|
don't do it at once. do it for each of the commits. it's not that big. |
Member
|
@KalmeMarq is this ready? please pull from main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create-react-app to vite
.editorconfig/.prettierrc
fixed broken links
fixed bugs
reduced pngs size