Skip to content

Conversation

@orbeckst
Copy link
Member

@orbeckst orbeckst commented Sep 8, 2025

Related to MDAnalysis/mdanalysis#4923

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

- state for each engine if they support concurrent connections
- minor markup/link reformatting
- moved information  from MDAnalysis/mdanalysis#4923 to here
@codecov
Copy link

codecov bot commented Sep 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.93%. Comparing base (07069e1) to head (1e854a9).

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@orbeckst orbeckst self-assigned this Sep 8, 2025
@ljwoods2
Copy link
Collaborator

ljwoods2 commented Sep 9, 2025

We've never tested multiple connections to the same port, so might be worth mentioning this is essentially undefined behavior. For example, when changing waiting behavior, does one client's requested change affect all others? If one client disconnects, does the simulation pause as long as at least one other client is connected?

@orbeckst
Copy link
Member Author

orbeckst commented Sep 9, 2025

Good points! Where should we write this in the docs @ljwoods2 ?

Copy link
Collaborator

@ljwoods2 ljwoods2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just include the information in-line like this?

Co-authored-by: ljwoods2 <145226270+ljwoods2@users.noreply.github.com>
@orbeckst
Copy link
Member Author

orbeckst commented Sep 9, 2025

Thanks @ljwoods2 !

@amruthesht
Copy link
Contributor

We've never tested multiple connections to the same port, so might be worth mentioning this is essentially undefined behavior. For example, when changing waiting behavior, does one client's requested change affect all others? If one client disconnects, does the simulation pause as long as at least one other client is connected?

@ljwoods2, @orbeckst - During the second NAMD-MR, fixing ordering and pause/disconnect issues in NAMD, I actually made sure the waiting behavior works and made IMDv3 changes taking care of the following -- whenever a client tells the MD engine to wait after disconnecting (using continue_after_disconnect=False), it will wait for another connection only if there are no other active clients. I put this in so other clients do not get stuck in the waited state. I have tested this by connecting multiple clients to the same port on NAMD.

@orbeckst
Copy link
Member Author

orbeckst commented Oct 17, 2025

@amruthesht given that you know that what is written in this PR so far is incomplete, please

  • review this PR with a "changes requested"
  • suggest changes or edit the PR itself

@orbeckst
Copy link
Member Author

Given that apparently our imdclient docs are the primary, authoritative documentation for NAMD-IMDv3, please make sure that you capture important information in the docs right away.

@orbeckst
Copy link
Member Author

@amruthesht can you please review the PR and suggest changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants