Skip to content

Avoid using memory mapping on AMD #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michaliskambi wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Avoid using memory mapping on AMD #49

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b38a45e
Avoid using memory mapping on AMD
michaliskambi Dec 22, 2025
ccba1fa
Merge branch 'BeRo1985:master' into master
michaliskambi Jan 13, 2026
7e70402
Merge branch 'BeRo1985:master' into master
michaliskambi Jan 16, 2026
ef80985
Merge branch 'BeRo1985:master' into master
michaliskambi Jan 20, 2026
a2a060c
Merge branch 'BeRo1985:master' into master
michaliskambi Jan 26, 2026
e875f2f
Merge branch 'BeRo1985:master' into master
michaliskambi Jan 28, 2026
c47b528
Merge branch 'BeRo1985:master' into master
michaliskambi Feb 2, 2026
79847c7
Merge branch 'BeRo1985:master' into master
michaliskambi Feb 6, 2026
f7cbb59
Merge branch 'BeRo1985:master' into master
michaliskambi Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/PasVulkan.Framework.pas
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16966,9 +16966,14 @@ function TpvVulkanDeviceMemoryStaging.Download(const aTransferQueue:TpvVulkanQue
Source:Pointer;
Destination:PpvUInt8;
VkBufferCopy:TVkBufferCopy;
EnableMemoryMap:boolean;
begin
{ Using Move for memory-mapped buffer causes hands at AMD. }
EnableMemoryMap:=Device.PhysicalDevice.Properties.vendorID<>
TpvUInt32(TpvVulkanVendorID.AMD);

if (TpvVulkanBufferFlag.PersistentMapped in aSourceBuffer.fBufferFlags) and
if EnableMemoryMap and
(TpvVulkanBufferFlag.PersistentMapped in aSourceBuffer.fBufferFlags) and
((aSourceBuffer.fMemoryPropertyFlags and TVkMemoryPropertyFlags(VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT))<>0) then begin

Source:=aSourceBuffer.Memory.MapMemory;
Expand Down