[CI baseline, do not merge] upstream c20dbc6 vs BatchZero/master#2
Closed
BatchZero wants to merge 18 commits into
Closed
[CI baseline, do not merge] upstream c20dbc6 vs BatchZero/master#2BatchZero wants to merge 18 commits into
BatchZero wants to merge 18 commits into
Conversation
This shaves off around 33% of runtime in `mtkcompile` for the model I am testing it on: Before: ``` 11.193316 seconds (136.79 M allocations: 6.120 GiB, 6.71% gc time) ``` After: ``` 7.570217 seconds (85.88 M allocations: 3.767 GiB, 4.58% gc time) ```
refactor: use `IRInfo` and `IRStructure` for `full_equations`
avoid calling `unhack_system` twice for the same `system`
…ructor` This used to be the lion's share of the compile time in large models. The infrastructure added here might be useful in other places too.
Enables supporting ReverseDiff AD
fix: avoid generating massive functions in `get_mtkparameters_reconstructor`
build: bump MTKBase, MTK patch versions
kc/typos whitespace
Owner
Author
|
Experiment concluded. CI baseline established (47 Tests-workflow fails are upstream-baseline / codecov-token environment issues, not caused by any PR1 changes). Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Control PR for the PR1 CI baseline experiment — DO NOT MERGE.
Purpose: this branch is exactly upstream/master @ c20dbc6 with ZERO PR1 changes
on top. It exists to baseline what BatchZero CI looks like when the diff is
purely 'upstream commits since BatchZero/master @ 46f2ef2' — no homotopy
operator work added.
Comparison with sibling PR #1:
Failure delta between #2 and #1 isolates which CI reds are attributable to
the PR1 homotopy operator work vs which are inherited from the upstream
baseline (which is currently red on SciML's own CI).
Will be closed after the comparison is recorded.