Conversation
Contributor
|
Possibly relevant: #391 maybe things have changed since then. |
Contributor
Author
|
#391 was closed in favor of #493, which suggests that effectful should use litellm's logging backend. I did try litellm's |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR adds observability support (#605) through Langfuse and Weave. The implementation simply instruments template, tool, and other llm related operations to use the decorator provided by the respective framework. Langfuse requires a bit more effort because its native litellm support doesn't seem compatible with custom spans for effectful handlers. I had to write some code to populate cost and token information from the litellm response.
This PR is different from #632, which aims to provide more flexibility by hand-rolling some observability functionalities so they can be accessed by the programmer directly.