Skip to content

refactor central park birds in collab 2#132

Open
rfl-urbaniak wants to merge 173 commits intostaging-collab-2from
ru-cp-collab2
Open

refactor central park birds in collab 2#132
rfl-urbaniak wants to merge 173 commits intostaging-collab-2from
ru-cp-collab2

Conversation

@rfl-urbaniak
Copy link
Collaborator

@rfl-urbaniak rfl-urbaniak commented Oct 10, 2024

No description provided.

PalkaPuri added 30 commits August 7, 2024 14:32
@PalkaPuri
add_velocity function
8365331
@PalkaPuri
velocity predictor WIP
e2ee500
@PalkaPuri
wip
6a19ae4
@PalkaPuri
format/lint
b5dde8a
@PalkaPuri
specify forager column as int
a923457
@PalkaPuri
add warning
8cc4111
@PalkaPuri
format/lint
892da93
@PalkaPuri
rename f,t for clarity
f675d23
@PalkaPuri
rerun notebook
1ee7caa
@PalkaPuri
add docstrings
fcd34b2
@PalkaPuri
format/lint
dc950c2
@PalkaPuri
use inbuilt function for gaussian pdf
205235f
@PalkaPuri
merge changes from pp-collab2-compute-velocity
b476a17
@PalkaPuri
updated visualization
045e7d0
@PalkaPuri
add handling of nan values in visualization
05b3d90
@PalkaPuri
add _generate_pairwise_copying predictor
5774858
@PalkaPuri
format/lint
41a7787
@PalkaPuri
type hints
ab6ee7e
@PalkaPuri
add pairwise predictor and animation function
47679f3
@PalkaPuri
change velocity to backward looking
fac3f10
@PalkaPuri
Merge branch 'pp-collab2-compute-velocity' of https://github.com/Basi…
ddf4572 
…sResearch/collab-creatures into pp-collab2-pairwise-copying-pred
@PalkaPuri
docstrings and type hints
4b242d8
@PalkaPuri
generate function and typehints
82223c0
@PalkaPuri
Merge branch 'staging-collab-2' of https://github.com/BasisResearch/c…
11f5dce 
…ollab-creatures into pp-collab2-pairwise-copying-pred
@PalkaPuri
fixed naming, nan handling
0dec71b
@PalkaPuri
refactoring
ea399b2
@PalkaPuri
vicsek wip
9a2ec97
@PalkaPuri
update normalization of velocity predictors
033e565
@PalkaPuri
distance_to_next_move WIP
9c6854b
@PalkaPuri
Merge branch 'pp-collab2-vicsek-predictor' of https://github.com/Basi…
8bfa2d0 
…sResearch/collab-creatures into pp-collab2-howfarscore
@rfl-urbaniak rfl-urbaniak added the status:WIP Work-in-progress not yet ready for review label Oct 10, 2024
@review-notebook-app
Copy link

review-notebook-app bot commented Oct 10, 2024

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@dimkab dimkab self-requested a review October 17, 2024 19:03
@emackev
Copy link
Contributor

emackev commented Oct 17, 2024 •
edited
Loading

This looks really nice!! A couple comments:

  • The sparrow trajectories look too heavily subsampled (large discontinuities)
  • Needs explanations. The optimization plots look very cool, but are hard to understand. What does 'constraint failure' indicate? How should the arrows be interpreted?
  • I really like the gray proximity score plots! These are drawn from a posterior fit by the optimizer, right? Text explanations will be helpful.
  • The plot_predictor plots look pretty flat over wide regions, should the scaling and/or transparency be changed?

@rfl-urbaniak rfl-urbaniak changed the base branch from main to staging-collab-2 October 18, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dimkab dimkab Awaiting requested review from dimkab

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

status:WIP Work-in-progress not yet ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rfl-urbaniak @emackev @PalkaPuri @dimkab